Fix inconsistent dep graph stubs in Bzlmod tests #21037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cause failures when relying on `depGraph` containing `ModuleKey`s for all modules, which is the case in production.
github-actions
bot
added
team-ExternalDeps
Wyverald
approved these changes
Jan 25, 2024
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 26, 2024
These cause failures when relying on `depGraph` containing `ModuleKey`s for all modules, which is the case in production. Work towards bazelbuild#20997 Closes bazelbuild#21037. PiperOrigin-RevId: 601822357 Change-Id: Ifcad9d7b73835491c1f1fca975e05834057a6825
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
These cause failures when relying on `depGraph` containing `ModuleKey`s for all modules, which is the case in production. Work towards #20997 Closes #21037. Commit 27419e3 PiperOrigin-RevId: 601822357 Change-Id: Ifcad9d7b73835491c1f1fca975e05834057a6825 Co-authored-by: Fabian Meumertzheim <[email protected]>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cause failures when relying on
depGraphcontainingModuleKeys for all modules, which is the case in production.Work towards #20997